fix: session replay respect feature flag variants #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 10, 2024
|
@pauldambra would you mind taking a look? since I will need to implement this across SDKs |
marandaneto
commented
Oct 10, 2024
| @@ -49,6 +49,32 @@ class PostHogFeatureFlags { | |||
| } | |||
| } | |||
|
|
|||
| private func isRecordingActive(_ featureFlags: [String: Any], _ sessionRecording: [String: Any]) -> Bool { | |||
| var recordingActive = true | |||
There was a problem hiding this comment.
default is active since the sessionRecording is a Map and not a boolean unless I find the linkedFlag and can compare things
marandaneto
commented
Oct 10, 2024
Comment on lines
+144
to
+145
| for item in samplesByTask where item.key.state == .completed { | ||
| completedTasks[item.key] = item.value |
There was a problem hiding this comment.
just fixing a lint issue
marandaneto
commented
Oct 11, 2024
| @@ -120,15 +120,20 @@ class PostHogStorage { | |||
| } | |||
|
|
|||
| /** | |||
| There are cases where applications using posthog-ios want to share analytics data between host app and an app extension, Widget or App Clip. If there's a defined `appGroupIdentifier` in configuration, we want to use a shared container for storing data so that extensions correcly identify a user (and batch process events) | |||
| There are cases where applications using posthog-ios want to share analytics data between host app and | |||
There was a problem hiding this comment.
just fixed a lint issue (line_length)
|
@ioannisj @pauldambra done, please double check after changes, I will do Android next (Monday) |
ioannisj
approved these changes
Oct 14, 2024
| { | ||
| recordingActive = value == variant | ||
| } | ||
| // check for multi flag variant (any) |
There was a problem hiding this comment.
Should we clean up these comments here?
There was a problem hiding this comment.
I don't think so since it's a valid result from the API and might help while debugging things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
JS PR PostHog/posthog-js#1040
💚 How did you test it?
📝 Checklist